Add summary to side effect and mutable side effect #2699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
yuandrew
approved these changes
Oct 28, 2025
temporal-sdk/src/main/java/io/temporal/internal/replay/ReplayWorkflowContext.java
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/statemachines/SideEffectStateMachine.java
Show resolved
Hide resolved
| .build(); | ||
| addCommand(StateMachineCommandUtils.createRecordMarker(markerAttributes)); | ||
| addCommand(StateMachineCommandUtils.createRecordMarker(markerAttributes, metadata)); | ||
| metadata = null; // only used once |
There was a problem hiding this comment.
For my own understanding, why do we null after recording once? Is it because replay is the only time we'd re-create a marker, and we don't need this for replay?
There was a problem hiding this comment.
Otherwise we just hold the metadata in memory when we no longer need it, just a memory optimization.
Quinn-With-Two-Ns
force-pushed
the
side-effect-summary
branch
2 times, most recently
from
17deb8b to
3b53ae0
Compare
Quinn-With-Two-Ns
force-pushed
the
side-effect-summary
branch
from
3b53ae0 to
f0cafac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add summary to side effect and mutable side effect.
closes #2702
Note
Add summary options to side/mutable side effects and plumb user metadata into marker/events across runtime, with API overloads and tests verifying metadata.
SideEffectOptionsandMutableSideEffectOptionswithsummarysupport.Workflow.sideEffect(..)andmutableSideEffect(..)(and outbound interceptor methods) to accept options.UserMetadatafor timers, side effects, mutable side effects, child workflows, local activities, and Nexus operations.UserMetadatathroughSideEffectStateMachineandMutableSideEffectStateMachine; attach toRECORD_MARKERcommands.StateMachineCommandUtils.createRecordMarkerto accept optional metadata; update callers.ReplayWorkflowContext,WorkflowStateMachines, andSyncWorkflowContext.HistoryUtils.assertEventMetadata.Written by Cursor Bugbot for commit f0cafac. This will update automatically on new commits. Configure here.